Attention is currently required from: Furquan Shaikh, Paul Menzel, Kane Chen, Andrey Petrov, Patrick Rudolph, Karthik Ramasubramanian. Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56805 )
Change subject: soc/intel/apollolake: change LPDDR4 density enum definition ......................................................................
Patch Set 2:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56805/comment/a53e6230_e831c118 PS1, Line 7: define
enum definition?
Done
https://review.coreboot.org/c/coreboot/+/56805/comment/a8982b54_e61a6208 PS1, Line 13:
BUG=b:178665760
Done
File src/soc/intel/apollolake/meminit.c:
https://review.coreboot.org/c/coreboot/+/56805/comment/65042a4a_33f40060 PS1, Line 24: /* Per rank density in Gb */ : switch (density) { : case LP4_8Gb_DENSITY: : sz = 8; : break; : case LP4_12Gb_DENSITY: : sz = 12; : break; : case LP4_16Gb_DENSITY: : sz = 16; : break; : default: : printk(BIOS_ERR, "Invalid DRAM density: %d\n", density); : sz = 0; : break; : }
I think this can be now dropped completely and `sz` can be set directly to density since that is wha […]
Done
https://review.coreboot.org/c/coreboot/+/56805/comment/58a4178a_02a97bc4 PS1, Line 292: rank_density
nit: Update this to rank_density_gb to indicate that the rank density is now passed in Gb.
Done
https://review.coreboot.org/c/coreboot/+/56805/comment/2224794e_d215511d PS1, Line 295: int fsp_rank_density;
Nit: Add an empty line between declaration block and function body.
Done
https://review.coreboot.org/c/coreboot/+/56805/comment/69999843_40ee4639 PS1, Line 307: \n
Gb
Done