[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/fatcat: Apply GPIO configuration lock

[Cliff Huang (Code Review)]

Attention is currently required from: Bora Guvendik, Jérémy Compostella, Pranava Y N, Subrata Banik, Wonkyu Kim.

Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84902?usp=email )

Change subject: mb/google/fatcat: Apply GPIO configuration lock
......................................................................

Patch Set 3:

(2 comments)

This change is ready for review.

Patchset:

PS3:
> why we have to lock all the GPIO PADs? what if we have a GPO ? […]

Only configuration is locked. the TX states is not.

File src/mainboard/google/fatcat/variants/fatcat/gpio.c:

https://review.coreboot.org/c/coreboot/+/84902/comment/ec50d2d8_fb9361e6?usp... :
PS3, Line 404: static const gpio_t gpio_lock_exception_table[] = {
> i'm unable to follow what all PAD configuration should reside here ?

This exception list for not locking is empty for now as we haven't identified the pads that OS driver or ACPI need to modify the configuration currently.