Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33760 )
Change subject: soc/amd/picasso: Make romstage a hybrid ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33760/1/src/soc/amd/picasso/include/soc/roms... File src/soc/amd/picasso/include/soc/romstage.h:
https://review.coreboot.org/#/c/33760/1/src/soc/amd/picasso/include/soc/roms... PS1, Line 26: truct early_saved_info { : uint32_t unused; : uint32_t bist; : uint64_t early_tsc; : } __packed; : Nice trick pushing it into stack and landing in the structure. Maybe add a comment explaining how it happens? Not obvious if I had not read the code that does the push before reading this patch.