Attention is currently required from: Bora Guvendik, Subrata Banik, Selma Bensaid, Tim Wawrzynczak, Paul Menzel, Julius Werner, Patrick Rudolph.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59507 )
Change subject: soc/intel/alderlake: Inject CSE TS into CBMEM timestamp table
......................................................................
Patch Set 16:
(3 comments)
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/59507/comment/77ba52fd_ac80d957
PS16, Line 149: SOC_INTEL_CSE_PRE_CPU_TELEMETRY
nit: SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY?
If agreed, you might need to change in other places too.
https://review.coreboot.org/c/coreboot/+/59507/comment/63d00c96_ea3d98e4
PS16, Line 153: performance
: telemetry data.
nit: pre - cpu reset boot performance telemetry data.
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/59507/comment/645bb32b_8d776fec
PS16, Line 501: cse_get_bootperformance_data
nit: cse_get_boot_performance_data?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59507
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idcdbb69538ca2977cd97ce1ef9b211ff6510a3f8
Gerrit-Change-Number: 59507
Gerrit-PatchSet: 16
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.corp-partner.google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 09 Feb 2022 18:47:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment