Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45648 )
Change subject: volteer: Create boldar variant
......................................................................
Patch Set 3:
"HAVE_SPD_BIN_IN_CBFS is set but SPD_SOURCES is empty"
so I think you'll need a mb/google/volteer/variants/boldar/memory/Makefile.inc that declares the SPD_SOURCES (and eventually use the scripts to generate SPDs)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45648
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92b4b917448d8e5e9176cb983adf7b209956d2c2
Gerrit-Change-Number: 45648
Gerrit-PatchSet: 3
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: siemens-bot
Gerrit-Comment-Date: Wed, 23 Sep 2020 15:41:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment