[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/pmc: Add PMC API for low power programming

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45794 )

Change subject: soc/intel/common/block/pmc: Add PMC API for low power programming
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45794/6/src/soc/intel/common/block/... 
File src/soc/intel/common/block/pmc/Kconfig:

https://review.coreboot.org/c/coreboot/+/45794/6/src/soc/intel/common/block/... 
PS6, Line 36: 	  Enable this for PMC devices to perform registers programming
            : 	  to ensure low power in active idle scenario.
            :
> sorry didn't get you. […]

I should have commented way clearer :-) actually this Kconfig does not cause code to be run but to be built and linked.

Ack on the XTAL and PM timer, however, fsp does parts of that already. I'm working on some changes for that, but it'll take some ... hours maybe or a bit less