Attention is currently required from: Martin L Roth, Arthur Heymans, Martin Roth, Fred Reitberger.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71673 )
Change subject: Kconfig: Add option to compress ramstage with LZ4 ......................................................................
Patch Set 2:
(4 comments)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/71673/comment/16a06b29_c44283dc PS1, Line 173: config MB_COMPRESS_RAMSTAGE_LZ4
Changing FSP-M to LZ4 instead of LZMA slowed things down significantly, so I think it's worth having […]
Ack
https://review.coreboot.org/c/coreboot/+/71673/comment/b7310957_a084df33 PS1, Line 180: depends on HAVE_RAMSTAGE && !UNCOMPRESSED_RAMSTAGE
The option is set to false and hidden. […]
Ack
https://review.coreboot.org/c/coreboot/+/71673/comment/72184e00_d0fbfec3 PS1, Line 181: default COMPRESS_RAMSTAGE_LZ4 if MB_COMPRESS_RAMSTAGE_LZ4
No, the first option will be the default if there's no other default specified. […]
Yes, please do, I think we're doing that on all choice options. That it automatically defaults to the first is news to me, that seems like a very obscure thing to rely upon.
https://review.coreboot.org/c/coreboot/+/71673/comment/16832ae0_6f92cd6f PS1, Line 192: Compress ramstage with LZ4 for faster decompression
Yeah, this was kind of a throw-away help string on my part. […]
Sure, I'm not saying that you can explain every possible situation here, just give people an idea what the relevant factors are (as far as we know them). It would also be good to add that it can be complicated and should always be tested in practice.