Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83549?usp=email )
(
4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/brya/variants/orisa: Change board strap memory config ......................................................................
mb/google/brya/variants/orisa: Change board strap memory config
Reorder GPIO pin mapping as per platform documentation: * GPIO_MEM_CONFIG_0 -> GPP_E2 * GPIO_MEM_CONFIG_1 -> GPP_E1 * GPIO_MEM_CONFIG_2 -> GPP_E12 * GPIO_MEM_CONFIG_3 -> NC
BUG=None TEST=emerge-nissa coreboot
Change-Id: I4e979686833095a904b114500dc1142def583afa Signed-off-by: Rishika Raj rishikaraj@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83549 Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: Amanda Hwang amanda_hwang@compal.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subratabanik@google.com --- M src/mainboard/google/brya/variants/orisa/memory.c 1 file changed, 5 insertions(+), 4 deletions(-)
Approvals: Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified Amanda Hwang: Looks good to me, approved Eric Lai: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/brya/variants/orisa/memory.c b/src/mainboard/google/brya/variants/orisa/memory.c index 2d73855..272a901 100644 --- a/src/mainboard/google/brya/variants/orisa/memory.c +++ b/src/mainboard/google/brya/variants/orisa/memory.c @@ -78,14 +78,15 @@ { /* * Memory configuration board straps - * GPIO_MEM_CONFIG_0 GPP_E1 - * GPIO_MEM_CONFIG_1 GPP_E2 + * GPIO_MEM_CONFIG_0 GPP_E2 + * GPIO_MEM_CONFIG_1 GPP_E1 * GPIO_MEM_CONFIG_2 GPP_E12 + * GPIO_MEM_CONFIG_3 NC */ gpio_t spd_gpios[] = { - GPP_E1, GPP_E2, - GPP_E12, + GPP_E1, + GPP_E12 };
return gpio_base2_value(spd_gpios, ARRAY_SIZE(spd_gpios));