Josie Nordrum has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44629 )
Change subject: mb/google/zork/var/ezkinil: Fix stylus GPIO to enable suspend ......................................................................
Patch Set 3:
(7 comments)
https://review.coreboot.org/c/coreboot/+/44629/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44629/1//COMMIT_MSG@9 PS1, Line 9: .
It would be good to add reason: None of the Ezkinil SKUs use internal stylus and hence pen pads are […]
Done
https://review.coreboot.org/c/coreboot/+/44629/1//COMMIT_MSG@9 PS1, Line 9: Move interrupt status : and wake status clearing to after GPIO config.
This should go in as a separate change.
Done
https://review.coreboot.org/c/coreboot/+/44629/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44629/2//COMMIT_MSG@7 PS2, Line 7: Ezkinil
mb/google/zork/var/ezkinil
Done
https://review.coreboot.org/c/coreboot/+/44629/2//COMMIT_MSG@13 PS2, Line 13: None
Verified that pen detect GPIO does not cause spurious wakes?
Done
https://review.coreboot.org/c/coreboot/+/44629/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/gpio.c:
https://review.coreboot.org/c/coreboot/+/44629/1/src/mainboard/google/zork/v... PS1, Line 11: PEN_DETECT_ODL
Maybe "PEN_DETECT_ODL - Not used" or "PEN_DETECT_ODL - Not connected"
Done
https://review.coreboot.org/c/coreboot/+/44629/1/src/mainboard/google/zork/v... PS1, Line 13:
Same here.
Done
https://review.coreboot.org/c/coreboot/+/44629/1/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:
PS1:
This is not related to the GPIO_4/GPIO_5 change. Should go in as a separate CL.
Done