You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32120 )
Change subject: google/kukui: Configure AP_IN_SLEEP_L correctly
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/32120/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32120/1//COMMIT_MSG@7
PS1, Line 7: google/kukui: Configure AP_IN_SLEEP_L correctly.
Please remove the dot/period at the end of the git commit message summary.
Done
https://review.coreboot.org/#/c/32120/1//COMMIT_MSG@10
PS1, Line 10: SPM
What is SPM?
It's MTK's power management component. Description added.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32120
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a7e34f95381dec17eb6d166d6552c12e021bd9a
Gerrit-Change-Number: 32120
Gerrit-PatchSet: 2
Gerrit-Owner: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 09 Apr 2019 04:58:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment