[coreboot-gerrit] [XL] Change in coreboot[main]: soc/intel/snowridge: Add support for Intel Atom Snow Ridge SoC

[Name of user not set (Code Review)]

Attention is currently required from: Elyes Haouas, Felix Singer, Jérémy Compostella, Shuo Liu, Vasiliy Khoruzhick.

[e-mail] has posted comments on this change by [e-mail]. ( https://review.coreboot.org/c/coreboot/+/83321?usp=email )

Change subject: soc/intel/snowridge: Add support for Intel Atom Snow Ridge SoC
......................................................................

Patch Set 24:

(2 comments)

File src/soc/intel/snowridge/systemagent.c:

https://review.coreboot.org/c/coreboot/+/83321/comment/e02291a7_cda9b29d?usp... :
PS21, Line 53: {
> here we need to rename resource_cnt to resource_index as well.

Done

https://review.coreboot.org/c/coreboot/+/83321/comment/2f8c528b_02cfc28c?usp... :
PS21, Line 77: 					    &snr_configurable_resources[i].resources, 1);
> here, can we omit the parameter '1'? a.k.a. for all cases, only one resource is added once.

SNR defines this following structure:
```
struct sa_configurable_mmio_descriptor {
    struct sa_mmio_descriptor resources;
    void (*get_resource)(struct device *dev, uint16_t index, uint64_t *base,
    		     uint64_t *size);
};
```
The code here is to call `get_resource()` to fill `resources` first, and then call `sa_add_fixed_mmio_resources()` with `resources`.