Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48182 )
Change subject: soc/amd: factor out common AOAC definitions
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48182/1/src/soc/amd/common/block/in...
File src/soc/amd/common/block/include/amdblocks/aoac.h:
https://review.coreboot.org/c/coreboot/+/48182/1/src/soc/amd/common/block/in...
PS1, Line 12: AOACx0000[40...7E]
ah, that's what the step 2 I removed there is about. […]
i ended up using even/odd byte addresses there which is imho easier to understand
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48182
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib882927e399031c376738e5a35793b3d7654b9cf
Gerrit-Change-Number: 48182
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 01 Dec 2020 20:36:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment