Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Andrey Petrov, Patrick Rudolph, HAOUAS Elyes.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49506 )
Change subject: src/cpu: Add EXPERIMENTAL_X86_64 option
......................................................................
Patch Set 17:
(3 comments)
Patchset:
PS17:
hm, this is useful to see what breaks in a 64 bit build (quite a bit and often in unexpected places), but it addds quite a bit of clutter, so i'm not really sure if i'd like this approach to be merged
File src/soc/amd/cezanne/Kconfig:
https://review.coreboot.org/c/coreboot/+/49506/comment/75b663c4_ff8e8c11
PS14, Line 13: select ARCH_ALL_STAGES_X86_32 if !ARCH_EXP_X86_64
like in picasso verstage can either be arm or x86, all stages is wrong here
File src/soc/amd/stoneyridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/49506/comment/96c76a56_5c0ae080
PS14, Line 16: select ARCH_ALL_STAGES_X86_64 if ARCH_EXP_X86_64
haven't looked into the details, but x86_64 will probably break the binaryPI integration without switching back to 32 bit mode before calling into the binary like the fsp 2 driver does
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49506
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8643467c82d7db9f40e09aad852bbc60ef82192
Gerrit-Change-Number: 49506
Gerrit-PatchSet: 17
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 29 Jan 2021 15:58:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment