Attention is currently required from: Felix Singer, Paul Menzel.
Ronald Claveau has posted comments on this change by Ronald Claveau. ( https://review.coreboot.org/c/coreboot/+/83104?usp=email )
Change subject: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge) ......................................................................
Patch Set 12:
(8 comments)
Patchset:
PS12: Thanks for your review, I understand more and more
File src/mainboard/dell/xps_8300/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83104/comment/ff2b7790_f06c20e5?usp... : PS11, Line 1: chip northbridge/intel/sandybridge
Done
https://review.coreboot.org/c/coreboot/+/83104/comment/1aa7ea86_793e4596?usp... : PS11, Line 6: register "gen1_dec" = "0x003c0a01"
Move this into the scope of the LPC controller
Done
https://review.coreboot.org/c/coreboot/+/83104/comment/695a3222_9f7a86b3?usp... : PS11, Line 8: register "sata_interface_speed_support" = "0x3" :
Move these into the scope of the SATA controller
Done
https://review.coreboot.org/c/coreboot/+/83104/comment/53ad017b_ecbe69f8?usp... : PS11, Line 30: # Management Engine Interface 1
These comments duplicate the alias names. Remove them as well.
Done
https://review.coreboot.org/c/coreboot/+/83104/comment/8c6324ba_59f5d305?usp... : PS11, Line 33: off
Remove all devices which are turned off. They are disabled in the chipset devicetree.
Done
File src/mainboard/dell/xps_8300/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/83104/comment/fc30fa48_0f9ae07b?usp... : PS11, Line 5:
nit: Remove one blank line
Done
File src/mainboard/dell/xps_8300/early_init.c:
https://review.coreboot.org/c/coreboot/+/83104/comment/78c899df_8842624d?usp... : PS11, Line 3:
nit: Remove one blank line
Done