Attention is currently required from: Benjamin Doron, Maximilian Brune, Angel Pons.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73894 )
Change subject: Revert "mb/starlabs/*: Remove sleepstates.asl" ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Misses those, created PR and what not - S4 works on my ADL with it. […]
Tried that patch on TGL, seems to assert on: ``` Loading driver CBD2E4D5-7068-4FF5-B462-9822B4AD8D60 InstallProtocolInterface: 5B1B31A1-9562-11D2-8E3F-00A0C969723B 763D8440 Loading driver at 0x0007676E000 EntryPoint=0x00076777EBF VariableRuntimeDxe.efi InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF 763D8998 ProtectUefiImageCommon - 0x763D8440 - 0x000000007676E000 - 0x0000000000011000 SetUefiImageMemoryAttributes - 0x000000007676E000 - 0x0000000000001000 (0x0000000000004000) SetUefiImageMemoryAttributes - 0x000000007676F000 - 0x000000000000E000 (0x0000000000020000) SetUefiImageMemoryAttributes - 0x000000007677D000 - 0x0000000000002000 (0x0000000000004000) PROGRESS CODE: V03040002 I0 VarCheckLibRegisterSetVariableCheckHandler - 0x767743B6 Success Variable driver common space: 0xFF9C 0xFF9C 0xFF9C
DXE_ASSERT!: [VariableRuntimeDxe] /home/sean/Documents/coreboot/payloads/external/edk2/workspace/starlabsltd/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableNonVolatile.c (280): GetNonVolatileMaxVariableSize () < (VariableStoreLength - sizeof (VARIAB ```