Attention is currently required from: Wonkyu Kim, Subrata Banik, John Zhao, Angel Pons, Nick Vaccaro, Eric Lai, Patrick Rudolph, Felix Held.
Hello build bot (Jenkins), Wonkyu Kim, Tim Wawrzynczak, John Zhao, Angel Pons, Nick Vaccaro, Eric Lai, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62778
to look at the new patch set (#4).
Change subject: soc/intel/common/block/p2sb: Add helper function to enable BAR
......................................................................
soc/intel/common/block/p2sb: Add helper function to enable BAR
This patch creates a new helper function to enable P2SB BAR.
`p2sb_dev_enable_bar()` takes the PCI P2SB device address (B/D/F)
and BAR address (combining high and low base addresses).
BUG=b:224325352
TEST=Able to build and boot brya.
Signed-off-by: Subrata Banik subratabanik@google.com
Change-Id: Ica41e8e8bdfcfe855e730b3878b874070062ef93
---
M src/soc/intel/common/block/include/intelblocks/p2sblib.h
M src/soc/intel/common/block/p2sb/Makefile.inc
M src/soc/intel/common/block/p2sb/p2sb.c
M src/soc/intel/common/block/p2sb/p2sblib.c
4 files changed, 14 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/62778/4
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62778
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica41e8e8bdfcfe855e730b3878b874070062ef93
Gerrit-Change-Number: 62778
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Wonkyu Kim
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: newpatchset