[coreboot-gerrit] Change in coreboot[master]: [WIP] mb/google,intel: Split chromeos.c files

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Jason Glenesk, Marshall Dawson, Tim Wawrzynczak, Nick Vaccaro, Julius Werner, Fred Reitberger, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59011 )

Change subject: [WIP] mb/google,intel: Split chromeos.c files
......................................................................

Patch Set 8:

(1 comment)

File src/mainboard/google/eve/chromeos.c:

https://review.coreboot.org/c/coreboot/+/59011/comment/7cad7fc6_2dcd622e 
PS6, Line 26: 	CROS_GPIO_WP_AH(GPIO_PCH_WP, CROS_GPIO_DEVICE_NAME),
> Yes, that is true, I am not sure if/why these are still required anymore, because crossystem will fa […]

Actually, I meant if the use of line above with CROS_GPIO_VIRTUAL was still valid, I can see recovery_mode_switch filled in vboot context, and entry in CRHW.GPIO appears to be unusable as it does not store the state.

As for WP, I do not see VBSD_BOOT_FIRMWARE_WP_ENABLED being set anywhere, and only mrc_cache code calls get_write_protect_state().