Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/63716?usp=email )
Change subject: [RFC]util/cbfstool: Rewrite trampoline in C ......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS1:
Is there another way to make it easier to chain load from other payloads?
Well I suppose you need to check if memory will overlap when loading one which I hope chainloaders do. So this is not an issue.
Patchset:
PS4:
Are you still working on this, or should it be abandoned?
Not right now.
What's the benefit to rewriting the code? The ASM has been tested and doesn't rely on GCC's interpretation of inline asm?
What's the benefit of coding in C rather than assembly? Also GCC is used for the assembly just as much as it is for inline assembly so I don't understand your argument about GCC interpretation of inline assembly. Making a 64bit version of this would trivial if it's compiled. Assembly would be pain.
The ASM is well tested and doesn't really change much.
Then the same would apply to a C version.