Attention is currently required from: Hsuan-ting Chen, Nick Vaccaro, Julius Werner, Andrey Petrov, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57951 )
Change subject: Revert "vboot_logic: Set VB2_CONTEXT_EC_TRUSTED in verstage_main"
......................................................................
Patch Set 2: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57951/comment/58ec7ea2_0e5f57f7
PS2, Line 11: intel
Intel
https://review.coreboot.org/c/coreboot/+/57951/comment/6d48b4f5_10621d5a
PS2, Line 11: intel
Intel
https://review.coreboot.org/c/coreboot/+/57951/comment/74d113e6_d1392d9f
PS2, Line 11: We need to add GPIO_EC_IN_RW into early_gpio_table for platforms using intel SoC
Please add a dot/period to the end of sentences.
Patchset:
PS2:
Three nits.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57951
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaeb1bf598047160f01e33ad0d9d004cad59e3f75
Gerrit-Change-Number: 57951
Gerrit-PatchSet: 2
Gerrit-Owner: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Attention: Hsuan-ting Chen
roccochen@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 09 Oct 2021 08:20:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment