Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40621 )
Change subject: drivers/ipmi: Add function read_data_string() to make code cleaner ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40621/2/src/drivers/ipmi/ipmi_fru.c File src/drivers/ipmi/ipmi_fru.c:
https://review.coreboot.org/c/coreboot/+/40621/2/src/drivers/ipmi/ipmi_fru.c... PS2, Line 159: &info->manufacturer);
In the subsequent printk, please print out length, so that the log message shows whether some data w […]
In the current implementation, read_data_string() it would do some checks and print error message when failed, for example: Read product FRU file ID string. read_data_string:104 - failed due to length is zero
If the string is read successfully, no log would be printed, for example: Read product manufacturer string. memalign Enter, boundary 8, size 7, free_mem_ptr 0x6f9512f8 memalign 0x6f9512f8 Read product_name string. ... Does that meet the requirement?