16 Jul
2024
16 Jul
'24
11:44 p.m.
Attention is currently required from: Felix Singer.
Nico Huber has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83226?usp=email )
Change subject: Makefile.mk: Use one line per *_common flag ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83226/comment/55683b66_78db47e7?usp... : PS2, Line 10: It makes the list of options more readable. I don't see how. Now I have to look up and down which feels unnatural (I'm used to read line-wise).
If you have trouble finding something, please make more use of your editors search functions, then you don't have to re- arrange the world.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83226?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I33c500e6eb74daf1e66c2b5e07b50f81c0f4587d
Gerrit-Change-Number: 83226
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Attention: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Comment-Date: Tue, 16 Jul 2024 21:44:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No