Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34255 )
Change subject: [WIP] intel/fsp_baytrail: Fix use of HAVE_SMI_HANDLER ......................................................................
[WIP] intel/fsp_baytrail: Fix use of HAVE_SMI_HANDLER
SCI interrupts need to be programmed regardless?
Change-Id: I0ada4b2a16490a15d8036a9425c4f768f7b8f218 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/intel/fsp_baytrail/gpio.c 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/34255/1
diff --git a/src/soc/intel/fsp_baytrail/gpio.c b/src/soc/intel/fsp_baytrail/gpio.c index 8d4e090..2d3d435 100644 --- a/src/soc/intel/fsp_baytrail/gpio.c +++ b/src/soc/intel/fsp_baytrail/gpio.c @@ -192,6 +192,9 @@ uint32_t route_reg = 0; int i;
+ if (!CONFIG(HAVE_SMI_HANDLER)) + return; + for (i = 0; i < 8; i++) { /* SMI takes precedence and wake_en implies SCI. */ if (sus[i].smi) { @@ -207,9 +210,7 @@ } }
-#if CONFIG(HAVE_SMI_HANDLER) southcluster_smm_save_gpio_route(route_reg); -#endif }
static void setup_dirqs(const u8 dirq[GPIO_MAX_DIRQS],