Attention is currently required from: Alexander Couzens, Elyes Haouas, Evgeny Zinoviev.
Martin L Roth has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83860?usp=email )
Change subject: [Prepare for C23]i945: Use nullptr instead of NULL ......................................................................
Patch Set 4: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83860/comment/502f389e_b8745bcf?usp... : PS4, Line 7: [Prepare for C23] I'd probably remove the C23 text since it doesn't seem to be completely accurate. Maybe just "Use nullptr instead of NULL."
BTW, here's the argument paper for it: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2431.pdf
https://review.coreboot.org/c/coreboot/+/83860/comment/c0f67562_9d2b1584?usp... : PS4, Line 10: Maybe mention that nullptr was introduced in C11 spec and gcc 4.7. - https://en.cppreference.com/w/cpp/language/nullptr - https://stackoverflow.com/questions/16256586/how-to-enable-c11-on-later-vers...
coreboot switched to GCC 4.7.2 on October 25, 2021, prior to coreboot v4.1. - https://review.coreboot.org/c/coreboot/+/1609