Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42731 )
Change subject: mb/google/volteer/var/voxel: Update gpio settings and overridetree.cb ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42731/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/voxel/gpio.c:
https://review.coreboot.org/c/coreboot/+/42731/3/src/mainboard/google/voltee... PS3, Line 32: VRALERT_L just curious - do you want to change the comment to reflect that this is actually going to a test point?
https://review.coreboot.org/c/coreboot/+/42731/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/voxel/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42731/3/src/mainboard/google/voltee... PS3, Line 117: # SBU & HSL follow CC change to TYPEC_ORIENTATION_NORMAL (identical to port C1) since you have a retimer on this port.