[coreboot-gerrit] [XL] Change in coreboot[main]: drivers/option: Add forms in cbtables

[Lean Sheng Tan (Code Review)]

Attention is currently required from: Angel Pons, Benjamin Doron, Martin L Roth, Maximilian Brune, Nico Huber, Patrick Rudolph, Sean Rhodes, Werner Zeh.

Lean Sheng Tan has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/coreboot/+/74121?usp=email )

Change subject: drivers/option: Add forms in cbtables
......................................................................

Patch Set 27:

(6 comments)

File Documentation/drivers/cfr.md:

https://review.coreboot.org/c/coreboot/+/74121/comment/7247a78a_cc46756d?usp... :
PS27, Line 9: S
> lowercase s

Done

https://review.coreboot.org/c/coreboot/+/74121/comment/acb84c10_adafecc8?usp... :
PS27, Line 15: means
> meaning?

Done

https://review.coreboot.org/c/coreboot/+/74121/comment/6ff91763_2706ae67?usp... :
PS27, Line 24: it's
> its (there are multiple ocurrences)

Done

File src/commonlib/include/commonlib/cfr.h:

https://review.coreboot.org/c/coreboot/+/74121/comment/515aeb9a_764e9695?usp... :
PS27, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
> We should consider moving this to commonlib/bsd for interoperability. […]

Talked to Patrick as he also worked on this, he has no objection, so do i, so I changed.

https://review.coreboot.org/c/coreboot/+/74121/comment/a4b628cc_af17cd26?usp... :
PS27, Line 6: #include <stdint.h>
> Redundant, types.h already includes it.

Done

File src/drivers/option/cfr.c:

https://review.coreboot.org/c/coreboot/+/74121/comment/7601af2f_412f3422?usp... :
PS27, Line 42: 	data = (uint8_t *)(cfr_str + 1);
> Right, this is a variable length structure and we don't have a struct member for the data. […]

Done