Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19090 )
Change subject: nb/intel/gm45: Allow setting backlight pwm frequency from CBFS ......................................................................
Patch Set 2:
(5 comments)
I'm not sure about this. I don't want it to be easy for a user to not participate (e.g. not telling us about his panel). Also, I don't believe that this is easier than recompiling ;) Though, maybe it is for some blobby downstream distribution.
And, testing values is actually easier with a simple MMIO write from the OS.
Yes testing should be done from OS. It would be nice to document it (or have a tool since reg holds the divisor).
I agree that not having it is more likely to get participation into adding entries to the lookup table.
I guess this indeed mostly makes sense if you are tied to a certain git commit like a cb release or if one uses a binary, however it could also be a handy way of working around aging CCFL or weird working inverters.