Attention is currently required from: Raul Rangel, Paul Menzel.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63733 )
Change subject: ec/google/chromeec: allow custom command timeout
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63733/comment/1bfde4c4_1f613180
PS1, Line 16: 10 seconds
I've learned that for Nereid (IT81302 EC), the chip specifications say an erase could take nearly 30 seconds in total, and the 5 seconds I've observed is only slightly slower than the quoted typical speed.
Perhaps this timeout should be provided as a config option so platforms that need a lot of time can increase it while others won't wait too long in situations that fail for some other reason?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63733
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55d36479e680c34a8bff65776e7e295e94291342
Gerrit-Change-Number: 63733
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 21 Apr 2022 06:23:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment