Attention is currently required from: Mario Scheithauer, Werner Zeh.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76174?usp=email )
Change subject: mb/siemens/mc_apl1: Change define name from 'TX_DWORD3' to 'TX_DWORD3_P1'
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76174/comment/5adfc185_df8c6059 :
PS1, Line 7: Change define name from 'TX_DWORD3' to 'TX_DWORD3_P1'
Change name → Rename
Maybe:
Rename macro `TX_DWORD3` to `TX_DWORD3_P1`
https://review.coreboot.org/c/coreboot/+/76174/comment/293cffc7_5ce01db8 :
PS1, Line 11: §
Shift key was pressed. ;-)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76174?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09d17eeffbe84939297e739586f6b74ed3e2258b
Gerrit-Change-Number: 76174
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Thu, 29 Jun 2023 06:44:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment