Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43571 )
Change subject: mb/system76/lemp9/gpio: 2/2 Convert field macros to PAD_CFG ......................................................................
Patch Set 3:
(2 comments)
I am currently reworking this by checking schematics and board. Can we agree on dropping this one?
https://review.coreboot.org/c/coreboot/+/43571/3/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/gpio.h:
https://review.coreboot.org/c/coreboot/+/43571/3/src/mainboard/system76/lemp... PS3, Line 92: PAD_CFG_GPI_APIC(GPP_A11, NONE, PLTRST), I wonder, how that even passes buildbot... PAD_CFG_GPI_APIC(pad, pull, rst) is legacy (SOC_INTEL_COMMON_BLOCK_GPIO_LEGACY_MACROS) which is not used by CML. This should be PAD_CFG_GPI_APIC_HIGH(pad, pull, rst, trig, inv) instead, shouldn't it?
https://review.coreboot.org/c/coreboot/+/43571/3/src/mainboard/system76/lemp... PS3, Line 143: PAD_CFG_GPI_APIC same as above