[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Disable C1 C-state Demotion

[Ravishankar Sarawadi (Code Review)]

Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46438 )

Change subject: soc/intel/tigerlake: Disable C1 C-state Demotion
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46438/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46438/1//COMMIT_MSG@12 
PS1, Line 12: to C1 based on uncore auto-demote information.
> I wonder, what the autodemotion is useful for.

Auto-demotion conditionally demote the C7 logic to C1. This is specifically a performance feature. Currently, by enabling this bit, we are seeing no effect on performance, but power for google meets KPI is impacted. Hence, we disabled this bit as an interim solution.

https://review.coreboot.org/c/coreboot/+/46438/1//COMMIT_MSG@16 
PS1, Line 16:  eg 'Google Meets video call'
> Please give concrete numbers, and how that was measured.

Done