Attention is currently required from: Nick Vaccaro, Ren Kuo, Subrata Banik.
Karthik Ramasubramanian has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84124?usp=email )
Change subject: mb/google/brox/jubilant: Update GPE0 routing
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brox/variants/jubilant/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84124/comment/6f4b4b87_8e5d2b68?usp... :
PS4, Line 25: register "pmc_gpe0_dw1" = "GPP_F"
if wake sources are scattered across more than 3 GPIO bank then you can use GPIO Tier 1 register to add additional entries.
I am not seeing any precedence for that. Also chip config does not seem to support more than 3 entries. It seems we need to configure PMC as well as GPIO communities for every tier. Should I ask Intel's support on this one?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84124?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic4a7ca07eab0dab234ab025cf77bbb8093b6b9d1
Gerrit-Change-Number: 84124
Gerrit-PatchSet: 4
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Thu, 29 Aug 2024 18:28:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com