Attention is currently required from: Maciej Pijanowski, Jakub Czapiga, Karol Zmyslowski, Stefan Reinauer.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73934 )
Change subject: util/inteltool: Add support for Jasper Lake
......................................................................
Patch Set 22:
(4 comments)
Patchset:
PS22:
Still found some inconsistencies after trying out the patch on hardware
File util/inteltool/gpio_names/jasperlake.h:
https://review.coreboot.org/c/coreboot/+/73934/comment/6e60e8e7_9df11a21
PS22, Line 461: PCIe vGPIO
VGPIO_PCIE as the pad names indicate
https://review.coreboot.org/c/coreboot/+/73934/comment/dcbbbfc1_098aaa8c
PS22, Line 483: GPP_SYS_VGPIO_USB
Just VGPIO_USB, GPP_SYS_ prefix should be removed
https://review.coreboot.org/c/coreboot/+/73934/comment/16b8b3f7_ed84c2b1
PS22, Line 536: vGPIO_PADDING
Simply VGPIO, padding was left
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73934
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4134bd03f5544b5845cde998ee526e5ddd5b51d
Gerrit-Change-Number: 73934
Gerrit-PatchSet: 22
Gerrit-Owner: Karol Zmyslowski
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Karol Zmyslowski
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Wed, 19 Apr 2023 14:45:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment