Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31950 )
Change subject: device/pciexp_device: Add set_subsystem() for pciexp device
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/31950/5/src/soc/intel/common/pcie.c
File src/soc/intel/common/pcie.c:
https://review.coreboot.org/#/c/31950/5/src/soc/intel/common/pcie.c@24
PS5, Line 24: void pciexp_set_subsystem(struct device *dev, unsigned int vendor,
Same with this name, add _intel somewhere in there, if this register is specific to intel. […]
its related to PCIEXP hence pciexp.h should be more applicable?
I agree with _intel name.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31950
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fbed39ed448baf11f0e0786ce0ee94741d57237
Gerrit-Change-Number: 31950
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 19 Mar 2019 14:55:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment