[coreboot-gerrit] Change in coreboot[master]: drivers/intel/gma: hook up GMA for Skylake+

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39638 )

Change subject: drivers/intel/gma: hook up GMA for Skylake+
......................................................................

Patch Set 21:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39638/20/src/mainboard/intel/kunimi... 
File src/mainboard/intel/kunimitsu/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/39638/20/src/mainboard/intel/kunimi... 
PS20, Line 3: # Set backlight PWM value for eDP
            : 	register "gpu_pch_backlight_pwm_hz"	 = "200"	# PWM frequency
            : 
            : 	# Enable Panel as eDP and configure power delays
            : 	register "gpu_pp_up_delay_ms"		 = "200"	# T3
            : 	register "gpu_pp_backlight_on_delay_ms"  = "1"		# T7
            : 	register "gpu_pp_backlight_off_delay_ms" = "200"	# T9
            : 	register "gpu_pp_down_delay_ms"	 = "50"	# T10
            : 	register "gpu_pp_cycle_delay_ms"	 = "500"	# T12
> They do relate to the backlight. […]

they're necessary for libgfxinit, but not for ACPI backlight control