Attention is currently required from: Dinesh Gehlot, Julius Werner, Kapil Porwal.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76395?usp=email )
Change subject: src: Store CSE RW FW version during cse_fw_sync ......................................................................
Patch Set 14:
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/76395/comment/5a7b4fa5_cadd88db : PS1, Line 211: version = cbmem_add(CBMEM_ID_CSE_PARTITION_VERSION, sizeof(*version));
Although this patch is specifically for CSE lite, the patch series implements a framework to hold CBMEM entries if they are used earlier than CBMEM is initialized.
I agree that the current CSE storing could be easily done by static memory and synchronized when CBMEM is available. However, I believe that is a workaround to transport data over different stages. A more suitable implementation would be to use the proposed framework.
I disagree. This is done in multiple places and just requires 1 line in the linker script. Having a pre-ram in memory database is more code to achieve the same. Using linker scripts to define common symbols across stages is not a workaround, but an ubiquitous patern in coreboot.