Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33396 )
Change subject: util/amdfwtool: Add argument for soft fuse override
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/33396/1/util/amdfwtool/amdfwtool.c
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/#/c/33396/1/util/amdfwtool/amdfwtool.c@458
PS1, Line 458: pspdir->entries[count].addr = 1;
Ths makes '-T 0' silently act like '-T 1'. […]
Done
https://review.coreboot.org/#/c/33396/1/util/amdfwtool/amdfwtool.c@530
PS1, Line 530: amd_psp_fw_table[i].other = strtoull(str, &tmp, 16);
Assigned but unused tmp, should work with NULL as 2nd parameter.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33396
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26223f0b42ad28c43d9bd87419a2a8f719ee91cb
Gerrit-Change-Number: 33396
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:50:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment