Attention is currently required from: Jian Tong, Paul Menzel, Shelley Chen, Subrata Banik.
Kun Liu has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/83139?usp=email )
Change subject: drivers/spi/acpi: Add generic property list
......................................................................
Patch Set 7:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83139/comment/989f39f3_3be043a6?usp... :
PS5, Line 7: lotso:
Nit: `drivers/spi/acpi: Add generic property list`
Done
https://review.coreboot.org/c/coreboot/+/83139/comment/f87a2eae_382c1543?usp... :
PS5, Line 9: Add generic property list
Add generic property list to allow populating vendor specific device properties to ACPI SSDT table.
Done
File src/drivers/spi/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/83139/comment/3ca23104_65fdc90f?usp... :
PS5, Line 152: acpi_dp_add_property_list(dsd, config->property_list,
: config->property_count);
I think that these are indented one too many? Should be aligned with the comment in the line above?
Already aligned with the comment in the line above
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83139?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8b18e0a2925e6fd36e3a470bde9910661b7558b8
Gerrit-Change-Number: 83139
Gerrit-PatchSet: 7
Gerrit-Owner: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jinfang Mao
maojinfang@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Tue, 25 Jun 2024 03:23:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com