Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41069 )
Change subject: soc/amd/common/block/lpc: Add config options for eSPI ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41069/1/src/soc/amd/common/block/lp... File src/soc/amd/common/block/lpc/Kconfig:
https://review.coreboot.org/c/coreboot/+/41069/1/src/soc/amd/common/block/lp... PS1, Line 19: Select this option if mainboard uses eSPI instead of LPC (if supported
Thanks for evaluating the possibility. I think it's fine to move forward for now then.
Can't say that I really like this approach, but since this only affects Mandolin and not the boards that will be publicly available, I can live with this. The chrome devices have an eMMC that has the interface multiplexed with at least some of the LPC lines, so they'll only be using eSPI. Mandolin also has some other serial ports that might be used instead, so it likely won't completely break things