Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Paul Menzel has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85128?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/mediatek/mt8196: Add PMIC MT6363 ADC driver ......................................................................
Patch Set 23:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85128/comment/82b64782_c732f55a?usp... : PS23, Line 9: Add MT6363 AUXADC driver support. It’d be great if you elaborated a little.
File src/soc/mediatek/common/mt6363_sdmadc.c:
https://review.coreboot.org/c/coreboot/+/85128/comment/275f430b_302d7e18?usp... : PS23, Line 23: AUXADC_AVG_TIME Please append the unit to the name.
https://review.coreboot.org/c/coreboot/+/85128/comment/64adfd39_552738d9?usp... : PS23, Line 24: AUXADC_POLL_TIME Ditto.
https://review.coreboot.org/c/coreboot/+/85128/comment/4444c0e4_9d64d496?usp... : PS23, Line 64: int unsigned int