Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44159 )
Change subject: soc/intel/apollolake: Select ASAN_IN_ROMSTAGE
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44159/1/src/soc/intel/apollolake/Kc...
File src/soc/intel/apollolake/Kconfig:
https://review.coreboot.org/c/coreboot/+/44159/1/src/soc/intel/apollolake/Kc...
PS1, Line 108: select ASAN_IN_ROMSTAGE if ASAN_IN_RAMSTAGE
You select ASAN_IN_RAMSTAGE elsewhere and suddenly the romstage's behavior changes? I'm not sure I like that idea...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44159
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f2f965151a4ef4672f2f16979a6ad8492879aeb
Gerrit-Change-Number: 44159
Gerrit-PatchSet: 1
Gerrit-Owner: Harshit Sharma
harshitsharmajs@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 04 Aug 2020 07:17:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment