Attention is currently required from: Cliff Huang, Jérémy Compostella, Subrata Banik.
Pranava Y N has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84407?usp=email )
Change subject: mb/google/fatcat: Add override tree
......................................................................
Patch Set 13:
(2 comments)
File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84407/comment/f3ffc032_6e495f4c?usp... :
PS1, Line 79: [PchSerialIoIndexI2C4] = PchSerialIoPci,
I2C0 is function 0 (i.e. 00:15.0). We will need to enable it if any 00:15.[1.. […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/84407/comment/056276b3_c65bc355?usp... :
PS1, Line 157: device ref thc0 on end
This will be used for touchscreen with THC-i2c or THC-spi mode. In addition, this is function 0. […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84407?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d53
Gerrit-Change-Number: 84407
Gerrit-PatchSet: 13
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-CC: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Wed, 25 Sep 2024 05:35:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Pranava Y N
pranavayn@google.com