Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36062 )
Change subject: soc/intel/fsp_baytrail: use designware I2C driver
......................................................................
Patch Set 3:
Patch Set 3:
Can the format/style changes be done in a separate commit? Also, can the mainboard be adapted in a separate commit?
For style changes: sure!
For mainboard changes:
As the mainboard ptn3460 code directly uses the i2c functions which are refactored now (and therefore not available any more in the old style) separating mainboard changes from this patch would break the build for the commit. So I guess we need to keep them together.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36062
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b87bd7c27e4c1afcce7cd4225cca02599f43c60
Gerrit-Change-Number: 36062
Gerrit-PatchSet: 3
Gerrit-Owner: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Reviewer: Aaron Durbin
adurbin@gmail.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 16 Oct 2019 15:00:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment