[coreboot-gerrit] [M] Change in coreboot[master]: vc/amd/*,soc/amd/*: Add SVC call to get HSP Secure State

[Raul Rangel (Code Review)]

Attention is currently required from: Jason Glenesk, Martin L Roth, Matt DeVillier, Jon Murphy, Name of user not set #1004763, Martin Roth, Fred Reitberger, Karthik Ramasubramanian, Felix Held.

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71207 )

Change subject: vc/amd/*,soc/amd/*: Add SVC call to get HSP Secure State
......................................................................

Patch Set 5:

(1 comment)

File src/vendorcode/amd/fsp/cezanne/include/bl_uapp/bl_syscall_public.h:

https://review.coreboot.org/c/coreboot/+/71207/comment/03d2714d_b8aad38e 
PS1, Line 362: uint32_t svc_get_hsp_secure_state(uint32_t *hsp_secure_state);
> > What about declaring a default implementation weak in the common code that just returns an unimple […]

I agree with martin. We should have a `common.h` that declares methods like this. Then in the `verstage_main.c` we can include the `common.h` and guard the calls to the methods using `if CONFIG(XXX)`. This way we will get a linker error if a platform enables a feature but doesn't implement the calls.