Attention is currently required from: Arthur Heymans, ron minnich. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62574 )
Change subject: cbfstool/linux_trampoline: Fill the ACPI RSDP entry ......................................................................
Patch Set 6: Verified-1
(15 comments)
File util/cbfstool/linux_trampoline.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143124): https://review.coreboot.org/c/coreboot/+/62574/comment/bd73fbba_82d7d2ea PS6, Line 6: 0xcb, 0x0f, 0x84, 0xc5, 0x00, 0x00, 0x00, 0x8b, 0x59, 0x04, 0x01, 0xcb, 0x8b, 0x49, 0x14, 0x83, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143124): https://review.coreboot.org/c/coreboot/+/62574/comment/afc342e0_dde2c3a2 PS6, Line 6: 0xcb, 0x0f, 0x84, 0xc5, 0x00, 0x00, 0x00, 0x8b, 0x59, 0x04, 0x01, 0xcb, 0x8b, 0x49, 0x14, 0x83, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143124): https://review.coreboot.org/c/coreboot/+/62574/comment/5616d07c_80a89301 PS6, Line 11: 0xe8, 0x01, 0x09, 0x00, 0xbf, 0xd0, 0x02, 0x09, 0x00, 0x83, 0xf8, 0x00, 0x74, 0x2f, 0x83, 0x7f, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143124): https://review.coreboot.org/c/coreboot/+/62574/comment/851dd591_0fb89679 PS6, Line 11: 0xe8, 0x01, 0x09, 0x00, 0xbf, 0xd0, 0x02, 0x09, 0x00, 0x83, 0xf8, 0x00, 0x74, 0x2f, 0x83, 0x7f, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143124): https://review.coreboot.org/c/coreboot/+/62574/comment/68d29fdf_e98f7c41 PS6, Line 13: 0xe8, 0x83, 0x3b, 0x43, 0x75, 0x12, 0x8b, 0x43, 0x08, 0xa3, 0x70, 0x00, 0x09, 0x00, 0x8b, 0x43, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143124): https://review.coreboot.org/c/coreboot/+/62574/comment/2382bcee_b451ddde PS6, Line 13: 0xe8, 0x83, 0x3b, 0x43, 0x75, 0x12, 0x8b, 0x43, 0x08, 0xa3, 0x70, 0x00, 0x09, 0x00, 0x8b, 0x43, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143124): https://review.coreboot.org/c/coreboot/+/62574/comment/46361800_b2be7094 PS6, Line 14: 0x0c, 0xa3, 0x74, 0x00, 0x09, 0x00, 0xeb, 0x05, 0x83, 0x3b, 0x12, 0x75, 0x00, 0x03, 0x5b, 0x04, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143124): https://review.coreboot.org/c/coreboot/+/62574/comment/109e8efa_9451a48e PS6, Line 14: 0x0c, 0xa3, 0x74, 0x00, 0x09, 0x00, 0xeb, 0x05, 0x83, 0x3b, 0x12, 0x75, 0x00, 0x03, 0x5b, 0x04, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143124): https://review.coreboot.org/c/coreboot/+/62574/comment/afa165b2_ac0d17bd PS6, Line 15: 0x49, 0x0f, 0x85, 0x78, 0xff, 0xff, 0xff, 0xb8, 0x00, 0x00, 0x04, 0x00, 0xc7, 0x40, 0x10, 0xff, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143124): https://review.coreboot.org/c/coreboot/+/62574/comment/9b62bd0e_26ae78fa PS6, Line 15: 0x49, 0x0f, 0x85, 0x78, 0xff, 0xff, 0xff, 0xb8, 0x00, 0x00, 0x04, 0x00, 0xc7, 0x40, 0x10, 0xff, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143124): https://review.coreboot.org/c/coreboot/+/62574/comment/c0816c97_8cc73a76 PS6, Line 16: 0xff, 0x00, 0x00, 0xc7, 0x40, 0x14, 0x00, 0x9b, 0xcf, 0x00, 0xc7, 0x40, 0x18, 0xff, 0xff, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143124): https://review.coreboot.org/c/coreboot/+/62574/comment/01f9c4ac_e95d9bd2 PS6, Line 16: 0xff, 0x00, 0x00, 0xc7, 0x40, 0x14, 0x00, 0x9b, 0xcf, 0x00, 0xc7, 0x40, 0x18, 0xff, 0xff, 0x00, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143124): https://review.coreboot.org/c/coreboot/+/62574/comment/025413a1_46b70c9a PS6, Line 17: 0x00, 0xc7, 0x40, 0x1c, 0x00, 0x93, 0xcf, 0x00, 0xc6, 0x00, 0x2b, 0x89, 0x40, 0x02, 0x0f, 0x01, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143124): https://review.coreboot.org/c/coreboot/+/62574/comment/ed1cc63f_ab9b6f55 PS6, Line 17: 0x00, 0xc7, 0x40, 0x1c, 0x00, 0x93, 0xcf, 0x00, 0xc6, 0x00, 0x2b, 0x89, 0x40, 0x02, 0x0f, 0x01, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143124): https://review.coreboot.org/c/coreboot/+/62574/comment/b4b134ac_762b93f1 PS6, Line 18: 0x10, 0xbe, 0x00, 0x00, 0x09, 0x00, 0xff, 0x25, 0x14, 0x02, 0x09, 0x00, 0xf4, 0xeb, 0xfd please, no spaces at the start of a line