Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40621 )
Change subject: drivers/ipmi: Add function read_data_string() to make code cleaner
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40621/2/src/drivers/ipmi/ipmi_fru.c
File src/drivers/ipmi/ipmi_fru.c:
https://review.coreboot.org/c/coreboot/+/40621/2/src/drivers/ipmi/ipmi_fru.c...
PS2, Line 159: &info->manufacturer);
The check is done in read_data_string(), it would return 0 length if any error or there's no such da […]
In the subsequent printk, please print out length, so that the log message shows whether some data was read successfully.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40621
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1da8abaa682af802e5cda65e5021069daf4ee717
Gerrit-Change-Number: 40621
Gerrit-PatchSet: 5
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 13 May 2020 17:22:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment