Ben Chuang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43751 )
Change subject: drivers/genesyslogic/gl9763e: Add driver for Genesys Logic GL9763E
......................................................................
Patch Set 6:
(1 comment)
Patch Set 6:
(1 comment)
What platform is this being targeted to?
A variant which is based on Volteer2.
https://review.coreboot.org/c/coreboot/+/43751/6/src/drivers/genesyslogic/gl...
File src/drivers/genesyslogic/gl9763e/gl9763e.c:
https://review.coreboot.org/c/coreboot/+/43751/6/src/drivers/genesyslogic/gl...
PS6, Line 23: pci_update_config32(dev, VHS, ~VHS_REV_MASK, VHS_REV_R);
Where are the ASPM controls? And what does each of these lines do?
ASPM control is on Line 20.
L:18, set VHS to be writable.
L:19, set single AXI request.
L:20, L0s support is disabled.
L:21, set SSC to 30000 ppm.
L:22, enable SSC.
L:23, set VHS to read-only.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43751
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I158c79f5ac6e559f335b6b50092469c7b1646c56
Gerrit-Change-Number: 43751
Gerrit-PatchSet: 6
Gerrit-Owner: Ben Chuang
benchuanggli@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Greg Tu
greg.tu@genesyslogic.com.tw
Gerrit-CC: HsuanYang Chen
ynop77@gmail.com
Gerrit-CC: Jerry Hu
jerry.huyc@gmail.com
Gerrit-CC: Renius Chen
renius.chen@genesyslogic.com.tw
Gerrit-Comment-Date: Wed, 05 Aug 2020 02:11:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment