Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31420 )
Change subject: SMBIOS: Update Processor Information structure to v3.2.0 ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/31420/7/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31420/7/src/arch/x86/smbios.c@565 PS7, Line 565: t->core_count2 = t->core_count;
Shouldn't you add code that once the number of cores are truly know and found to be greater then 255 […]
I am fine with any solution that is consistent with the SMBIOS rules and doesn't read completely unrelated CPUID information.
Being accurate about the number of cores is a different matter.
https://review.coreboot.org/#/c/31420/7/src/include/smbios.h File src/include/smbios.h:
https://review.coreboot.org/#/c/31420/7/src/include/smbios.h@378 PS7, Line 378: u16 core_enabled2; : u16 thread_count2; If you add them, you have to fill them. If you don't want to fill them, don't add them.