Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41122 )
Change subject: cbfstool: Add support for platform "fixups" when modifying bootblock ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41122/8/util/cbfstool/platform_fixu... File util/cbfstool/platform_fixups.c:
https://review.coreboot.org/c/coreboot/+/41122/8/util/cbfstool/platform_fixu... PS8, Line 14: size_t search_end_size = MIN(0, buffer_size(in) - 32 * KiB); Should we ensure buffer_size(in) >= 32KiB?
https://review.coreboot.org/c/coreboot/+/41122/8/util/cbfstool/platform_fixu... PS8, Line 29: return NULL; /* Doesn't seem to be a Qualcomm image. */ because it matched w/ too early?