Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Angel Pons, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59509 )
Change subject: soc/intel/common/thermal: Refactor thermal block to improve reusability ......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/common/block/thermal/Kconfig:
https://review.coreboot.org/c/coreboot/+/59509/comment/3aa0c5a9_ef870a22 PS4, Line 7: config SOC_INTEL_COMMON_BLOCK_THERMAL_PCI_DEV : bool : default n : select SOC_INTEL_COMMON_BLOCK_THERMAL : help : This option allows to configure PCH thermal registers using Thermal PCI device : for chipsets till Ice Lake PCH. : : config SOC_INTEL_COMMON_BLOCK_THERMAL_BEHIND_PMC : bool : default n : select SOC_INTEL_COMMON_BLOCK_THERMAL : help : This option allows to configure PCH thermal registers using PMC PWRMBASE : for chipsets since Tiger Lake PCH.
Ack
@Angel, looks like its being considered as a recursive dependency.
Can you please take a look at the latest patch?
src/soc/intel/common/block/thermal/Kconfig:7:error: recursive dependency detected! src/soc/intel/common/block/thermal/Kconfig:7: symbol SOC_INTEL_COMMON_BLOCK_THERMAL_PCI_DEV depends on SOC_INTEL_COMMON_BLOCK_THERMAL_BEHIND_PMC src/soc/intel/common/block/thermal/Kconfig:16: symbol SOC_INTEL_COMMON_BLOCK_THERMAL_BEHIND_PMC depends on SOC_INTEL_COMMON_BLOCK_THERMAL_PCI_DEV For a resolution refer to Documentation/kbuild/kconfig-language.rst subsection "Kconfig recursive dependency limitations"