Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31729 )
Change subject: util/amdfwtool: Introduce combo-capable option
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31729/3/util/amdfwtool/amdfwtool.c
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/#/c/31729/3/util/amdfwtool/amdfwtool.c@172
PS3, Line 172: n
Nit: I guess this matches AMD_FW_PSP_SMU_FN_FIRMWARE, but for fanless, smufLfirmware would make more […]
And it's remove later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31729
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I249700c6addad1c0ecb495a406ffe7a022dd920b
Gerrit-Change-Number: 31729
Gerrit-PatchSet: 3
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 Mar 2019 23:35:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment